Skip to content

Update to LLVM 23 - #158734

Open
nikic wants to merge 11 commits into
rust-lang:mainfrom
nikic:llvm23
Open

Update to LLVM 23#158734
nikic wants to merge 11 commits into
rust-lang:mainfrom
nikic:llvm23

Conversation

@nikic

@nikic nikic commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

View all comments

Changes in this PR (apart from the LLVM update):

  • Updated cov-map tests due to minor ordering changes introduced in llvm/llvm-project@5931034. The affected tests are limited to LLVM >= 23 now.
  • Set LLVM_VERSIONED_DYLIB_NAME_ON_DARWIN=OFF, which restores the previous unversioned naming of the LLVM dylib on Darwin. I expect we'll want to change this for consistency with Linux, but given the amount of trouble Darwin dylibs have caused in the past, I'm not trying to do it in this PR.
  • Distribute the llvm-project/libc subproject, which is now a build dependency of LLVM.
  • Pull in f128 Windows ABI changes from adjust f128 windows abi for LLVM 23 #158778. These need to land in sync with the LLVM update (as ABI of libcalls is controlled by LLVM, not our ABI lowering).
  • Disable RISCV backend on dist-i686-mingw, because the build OOMs on a large generated file. This is a temporary measure until host tools are removed by Drop tier 2 i686-pc-windows-gnu host tools compiler-team#1020.
  • The llvm-project fork includes a new downstream patch for mingw: rust-lang/llvm-project@b89cd8e It works around mingw having broken TLS prior to GCC 16. (We're currently on GCC 14.)

Issues:

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 3, 2026
@nikic

nikic commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 3, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jul 3, 2026
@bors
Auto merge of #158734 - nikic:llvm23, r=<try>
b003a3f 
Update to LLVM 23
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

💔 Test for b003a3f failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 13, 2026
@nikic

nikic commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jul 13, 2026
@bors
Auto merge of #158734 - nikic:llvm23, r=<try>
0259978 
Update to LLVM 23
@rust-bors

rust-bors Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 0259978 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nikic

nikic commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jul 14, 2026
@bors
Auto merge of #158734 - nikic:llvm23, r=<try>
4973bfc 
Update to LLVM 23
@rust-bors

rust-bors Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 4973bfc failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: aa09ee3 (aa09ee35a320ae446ce3b94143b734551ab491c0)
Base parent: bf9944f (bf9944f0b8006b152ef4d5f408ae75a0dde3d044)

@rustbot

rustbot commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@Kobzol

Kobzol commented Jul 28, 2026

Copy link
Copy Markdown
Member

@bors r=cuviper

@rust-bors

rust-bors Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 60d1bbf has been approved by cuviper

It is now in the queue for this repository.

@ZuseZ4

ZuseZ4 commented Jul 28, 2026

Copy link
Copy Markdown
Member

@bors p=5 blocking other work
Also, we've been trying to merge it for a while

@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 1ccfdc3 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ZuseZ4

ZuseZ4 commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@davidtwco I'm just looking into it (#160042), but based on #152038 I assume you're more knowledgeable about this: A-key return address signing is unsupported on AArch64 Windows

@ZuseZ4

ZuseZ4 commented Jul 28, 2026

Copy link
Copy Markdown
Member

@jchlanda as the project goal owner for aarch64 pauth (even if linux) does the test update look good to you, or do you have any other simple solution at hand to unblock the update to LLVM 23?

@dianqk

dianqk commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

IIUC, llvm/llvm-project#203989 should use the B-key by default now.

Base on https://github.com/rust-lang/rust/blob/main/compiler/rustc_codegen_llvm/src/attributes.rs#L555 and llvm/llvm-project#203989, I think we should make key as an option value, so that LLVM can use the default value for each target.

@davidtwco

davidtwco commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@davidtwco I'm just looking into it (#160042), but based on #152038 I assume you're more knowledgeable about this: A-key return address signing is unsupported on AArch64 Windows

I don't think this is right, we should default to b-key in rustc for MSVC. I can make a patch for that. This has been on my to-do for a bit, just didn't expect it to break a LLVM upgrade.

@ZuseZ4 ZuseZ4 mentioned this pull request Jul 30, 2026
Open
@lqd lqd mentioned this pull request Jul 30, 2026
Merged
@ZuseZ4

ZuseZ4 commented Jul 31, 2026

Copy link
Copy Markdown
Member

perfect, I dropped the last commit and only left my earlier gcc fix, as well as Nikita's PR in here.
Once the proper fix lands someone can then just approve this one, I'll probably not be on my computer.

@Kobzol

Kobzol commented Jul 31, 2026

Copy link
Copy Markdown
Member

#160149 has landed, let's try.

@bors r=cuviper

@bors try jobs=aarch64-msvc-1

@rust-bors

rust-bors Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 60d1bbf has been approved by cuviper

It is now in the queue for this repository.

@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot mentioned this pull request Jul 31, 2026
Merged
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

💔 Test for af2b20b failed: CI. Failed job:

@rust-log-analyzer

rust-log-analyzer commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

The job dist-x86_64-illumos failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
warning: rustc_llvm@0.0.0:                  from /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/Passes/PassBuilder.h:19,
warning: rustc_llvm@0.0.0:                  from /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/LTO/Config.h:23,
warning: rustc_llvm@0.0.0:                  from /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/LTO/LTO.h:27,
warning: rustc_llvm@0.0.0:                  from llvm-wrapper/PassWrapper.cpp:21:
warning: rustc_llvm@0.0.0: /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/CodeGenTypes/LowLevelType.h:632:15: error: 'llvm::LLT::Info' is too small to hold all values of 'enum class llvm::LLT::Kind' [-Werror]
warning: rustc_llvm@0.0.0:    Kind Info : 4;
warning: rustc_llvm@0.0.0:                ^
warning: rustc_llvm@0.0.0: cc1plus: all warnings being treated as errors
error: failed to run custom build command for `rustc_llvm v0.0.0 (/checkout/compiler/rustc_llvm)`

Caused by:
  process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/rustc_llvm/f341b7794596f27c/out/build_script_build` (exit status: 1)
  --- stdout
  cargo:rustc-check-cfg=cfg(llvm_component,values("ipo"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("bitreader"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("bitwriter"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("linker"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("asmparser"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("lto"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("coverage"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("instrumentation"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("x86"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("arm"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("aarch64"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("amdgpu"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("avr"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("loongarch"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("m68k"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("csky"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("mips"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("powerpc"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("systemz"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("webassembly"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("msp430"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("sparc"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("nvptx"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("hexagon"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("riscv"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("xtensa"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("bpf"))
  cargo:rerun-if-env-changed=RUST_CHECK
  cargo:rerun-if-env-changed=REAL_LIBRARY_PATH_VAR
  cargo:rerun-if-env-changed=REAL_LIBRARY_PATH
  cargo:rerun-if-env-changed=LLVM_CONFIG
  cargo:rerun-if-changed=/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/bin/llvm-config
  cargo:rustc-cfg=llvm_component="aarch64"
  cargo:rustc-cfg=llvm_component="amdgpu"
  cargo:rustc-cfg=llvm_component="arm"
  cargo:rustc-cfg=llvm_component="asmparser"
  cargo:rustc-cfg=llvm_component="avr"
  cargo:rustc-cfg=llvm_component="bitreader"
  cargo:rustc-cfg=llvm_component="bitwriter"
  cargo:rustc-cfg=llvm_component="bpf"
  cargo:rustc-cfg=llvm_component="coverage"
  cargo:rustc-cfg=llvm_component="csky"
  cargo:rustc-cfg=llvm_component="hexagon"
  cargo:rustc-cfg=llvm_component="instrumentation"
  cargo:rustc-cfg=llvm_component="ipo"
  cargo:rustc-cfg=llvm_component="linker"
  cargo:rustc-cfg=llvm_component="loongarch"
  cargo:rustc-cfg=llvm_component="lto"
  cargo:rustc-cfg=llvm_component="m68k"
  cargo:rustc-cfg=llvm_component="mips"
  cargo:rustc-cfg=llvm_component="msp430"
  cargo:rustc-cfg=llvm_component="nvptx"
  cargo:rustc-cfg=llvm_component="powerpc"
  cargo:rustc-cfg=llvm_component="riscv"
  cargo:rustc-cfg=llvm_component="sparc"
  cargo:rustc-cfg=llvm_component="systemz"
  cargo:rustc-cfg=llvm_component="webassembly"
  cargo:rustc-cfg=llvm_component="x86"
  cargo:rustc-cfg=llvm_component="xtensa"
  cargo:rerun-if-env-changed=RUSTC_DEBUGINFO_MAP
  cargo:rerun-if-env-changed=LLVM_ENZYME
  cargo:rerun-if-env-changed=LLVM_OFFLOAD
  cargo:rerun-if-env-changed=LLVM_RUSTLLVM
  cargo:rerun-if-env-changed=LLVM_ASSERTIONS
  cargo:rerun-if-changed=llvm-wrapper/SuppressLLVMWarnings.h
  cargo:rerun-if-changed=llvm-wrapper/README
  cargo:rerun-if-changed=llvm-wrapper/Linker.cpp
  cargo:rerun-if-changed=llvm-wrapper/RustWrapper.cpp
  cargo:rerun-if-changed=llvm-wrapper/.editorconfig
  cargo:rerun-if-changed=llvm-wrapper/PassWrapper.cpp
  cargo:rerun-if-changed=llvm-wrapper/SymbolWrapper.cpp
  cargo:rerun-if-changed=llvm-wrapper/LLVMWrapper.h
  cargo:rerun-if-changed=llvm-wrapper/CoverageMappingWrapper.cpp
  OUT_DIR = Some(/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/build/rustc_llvm/3e9c3f4c9e1f7594/out)
  OPT_LEVEL = Some(3)
  TARGET = Some(x86_64-unknown-linux-gnu)
  HOST = Some(x86_64-unknown-linux-gnu)
  cargo:rerun-if-env-changed=CXX_x86_64-unknown-linux-gnu
  CXX_x86_64-unknown-linux-gnu = None
  cargo:rerun-if-env-changed=CXX_x86_64_unknown_linux_gnu
  CXX_x86_64_unknown_linux_gnu = Some(sccache c++)
  cargo:rerun-if-env-changed=CC_KNOWN_WRAPPER_CUSTOM
  CC_KNOWN_WRAPPER_CUSTOM = None
  cargo:rerun-if-env-changed=CC_ENABLE_DEBUG_OUTPUT
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some(false)
  CARGO_CFG_TARGET_FEATURE = Some(fxsr,sse,sse2,x87)
  cargo:rerun-if-env-changed=CXXFLAGS
  CXXFLAGS = None
  cargo:rerun-if-env-changed=HOST_CXXFLAGS
  HOST_CXXFLAGS = None
  cargo:rerun-if-env-changed=CXXFLAGS_x86_64_unknown_linux_gnu
  CXXFLAGS_x86_64_unknown_linux_gnu = Some(-fdebug-prefix-map=/checkout=/rustc/af2b20be44b9f9cec9f055a47ba0b49c9844ddc0)
  cargo:rerun-if-env-changed=CC_SHELL_ESCAPED_FLAGS
  CC_SHELL_ESCAPED_FLAGS = None
  cargo:rerun-if-env-changed=CXXFLAGS_x86_64-unknown-linux-gnu
  CXXFLAGS_x86_64-unknown-linux-gnu = None
  CARGO_ENCODED_RUSTFLAGS = Some(--cfg=windows_raw_dylib-Zunstable-options--check-cfg=cfg(bootstrap)-Zmacro-backtrace-Csplit-debuginfo=off-Clink-args=-Wl,-z,origin-Clink-args=-Wl,-rpath,$ORIGIN/../lib-Clink-arg=-Wl,--compress-debug-sections=zlib-Alinker-messages-Zon-broken-pipe=kill--cfg=bootstrap)
  OUT_DIR = Some(/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/build/rustc_llvm/3e9c3f4c9e1f7594/out)
  cargo:rerun-if-env-changed=CC_ENABLE_DEBUG_OUTPUT
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  TARGET = Some(x86_64-unknown-linux-gnu)
  CARGO_CFG_TARGET_FEATURE = Some(fxsr,sse,sse2,x87)
  HOST = Some(x86_64-unknown-linux-gnu)
  cargo:rerun-if-env-changed=CXXFLAGS
  CXXFLAGS = None
  cargo:rerun-if-env-changed=HOST_CXXFLAGS
  HOST_CXXFLAGS = None
  cargo:rerun-if-env-changed=CXXFLAGS_x86_64_unknown_linux_gnu
---
  OUT_DIR = Some(/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/build/rustc_llvm/3e9c3f4c9e1f7594/out)
  cargo:rerun-if-env-changed=CC_ENABLE_DEBUG_OUTPUT
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  TARGET = Some(x86_64-unknown-linux-gnu)
  CARGO_CFG_TARGET_FEATURE = Some(fxsr,sse,sse2,x87)
  HOST = Some(x86_64-unknown-linux-gnu)
  cargo:rerun-if-env-changed=CXXFLAGS
  CXXFLAGS = None
  cargo:rerun-if-env-changed=HOST_CXXFLAGS
  HOST_CXXFLAGS = None
  cargo:rerun-if-env-changed=CXXFLAGS_x86_64_unknown_linux_gnu
---
  OUT_DIR = Some(/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/build/rustc_llvm/3e9c3f4c9e1f7594/out)
  cargo:rerun-if-env-changed=CC_ENABLE_DEBUG_OUTPUT
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  TARGET = Some(x86_64-unknown-linux-gnu)
  CARGO_CFG_TARGET_FEATURE = Some(fxsr,sse,sse2,x87)
  HOST = Some(x86_64-unknown-linux-gnu)
  cargo:rerun-if-env-changed=CXXFLAGS
  CXXFLAGS = None
  cargo:rerun-if-env-changed=HOST_CXXFLAGS
  HOST_CXXFLAGS = None
  cargo:rerun-if-env-changed=CXXFLAGS_x86_64_unknown_linux_gnu
  CXXFLAGS_x86_64_unknown_linux_gnu = Some(-fdebug-prefix-map=/checkout=/rustc/af2b20be44b9f9cec9f055a47ba0b49c9844ddc0)
  cargo:rerun-if-env-changed=CC_SHELL_ESCAPED_FLAGS
  CC_SHELL_ESCAPED_FLAGS = None
  cargo:rerun-if-env-changed=CXXFLAGS_x86_64-unknown-linux-gnu
  CXXFLAGS_x86_64-unknown-linux-gnu = None
  cargo:warning=In file included from /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/CodeGen/MachineMemOperand.h:22:0,
  cargo:warning=                 from /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/CodeGen/MachineInstr.h:26,
  cargo:warning=                 from /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/CodeGen/MachineBasicBlock.h:22,
  cargo:warning=                 from /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/CodeGen/MachineFunction.h:26,
  cargo:warning=                 from /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/CodeGen/MachinePassManager.h:26,
  cargo:warning=                 from /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/Passes/PassBuilder.h:19,
  cargo:warning=                 from /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/LTO/Config.h:23,
  cargo:warning=                 from /checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/LTO/LTO.h:27,
  cargo:warning=                 from llvm-wrapper/PassWrapper.cpp:21:
  cargo:warning=/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include/llvm/CodeGenTypes/LowLevelType.h:632:15: error: 'llvm::LLT::Info' is too small to hold all values of 'enum class llvm::LLT::Kind' [-Werror]
  cargo:warning=   Kind Info : 4;
  cargo:warning=               ^
  cargo:warning=cc1plus: all warnings being treated as errors

  --- stderr


  error occurred in cc-rs: command did not execute successfully (status code exit status: 1): LC_ALL="C" "sccache" "c++" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-Werror" "-I/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/include" "-std=c++1z" "-D_GNU_SOURCE" "-D_GLIBCXX_USE_CXX11_ABI=1" "-D__STDC_CONSTANT_MACROS" "-D__STDC_FORMAT_MACROS" "-D__STDC_LIMIT_MACROS" "-fno-exceptions" "-fno-rtti" "-DLLVM_COMPONENT_AARCH64" "-DLLVM_COMPONENT_AMDGPU" "-DLLVM_COMPONENT_ARM" "-DLLVM_COMPONENT_ASMPARSER" "-DLLVM_COMPONENT_AVR" "-DLLVM_COMPONENT_BITREADER" "-DLLVM_COMPONENT_BITWRITER" "-DLLVM_COMPONENT_BPF" "-DLLVM_COMPONENT_COVERAGE" "-DLLVM_COMPONENT_CSKY" "-DLLVM_COMPONENT_HEXAGON" "-DLLVM_COMPONENT_INSTRUMENTATION" "-DLLVM_COMPONENT_IPO" "-DLLVM_COMPONENT_LINKER" "-DLLVM_COMPONENT_LOONGARCH" "-DLLVM_COMPONENT_LTO" "-DLLVM_COMPONENT_M68K" "-DLLVM_COMPONENT_MIPS" "-DLLVM_COMPONENT_MSP430" "-DLLVM_COMPONENT_NVPTX" "-DLLVM_COMPONENT_POWERPC" "-DLLVM_COMPONENT_RISCV" "-DLLVM_COMPONENT_SPARC" "-DLLVM_COMPONENT_SYSTEMZ" "-DLLVM_COMPONENT_WEBASSEMBLY" "-DLLVM_COMPONENT_X86" "-DLLVM_COMPONENT_XTENSA" "-DLLVM_RUSTLLVM" "-DNDEBUG" "-fdebug-prefix-map=/checkout=/rustc/af2b20be44b9f9cec9f055a47ba0b49c9844ddc0" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/build/rustc_llvm/3e9c3f4c9e1f7594/out/ef10e86dc40538c1-PassWrapper.o" "-c" "llvm-wrapper/PassWrapper.cpp"


warning: build failed, waiting for other jobs to finish...
[RUSTC-TIMING] rustc_type_ir test:false 3.719
[RUSTC-TIMING] rustc_target test:false 16.825

@RalfJung

RalfJung commented Jul 31, 2026

Copy link
Copy Markdown
Member

@jclulow @pfmooney looks like the Illumos runner uses an ancient GCC that cannot build LLVM 23

@rust-bors

rust-bors Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: db7ba90 (db7ba9036aa814f321e65bd65bb212a0a50dc47c)
Base parent: 922325b (922325bb13bfea5b41454318563f2a65e83c2336)

@ZuseZ4

ZuseZ4 commented Jul 31, 2026

Copy link
Copy Markdown
Member

I've updated it to 10.1.0, the same that I also used for netbsd. Let's see if it passes: #160042 (comment)

@jclulow

jclulow commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Please be sure to heed the comment about verifying the correctness of the binaries produced by the cross compiler if you're going to change the GCC version!

@RalfJung

RalfJung commented Jul 31, 2026

Copy link
Copy Markdown
Member

We would appreciate your help with that verification :)

@jclulow

jclulow commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

We would appreciate your help with that verification :)

I understand. It's midnight on Friday night and I just heard about this, so I wanted to make sure we're not just going to bump the number and move on before we take a look in the next couple of days. Thanks for the heads up.

@mati865 mati865 mentioned this pull request Jul 31, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dianqk dianqk dianqk left review comments
@ZuseZ4 ZuseZ4 ZuseZ4 left review comments
@bjorn3 bjorn3 bjorn3 approved these changes

Assignees

@cuviper cuviper

Labels

A-CI Area: Our Github Actions CI A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc F-autodiff `#![feature(autodiff)]` perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.